From 45d5200e6131c90005760fe33f9efbde308541f5 Mon Sep 17 00:00:00 2001
From: samuel <samuel.campos@netoik.io>
Date: Tue, 11 Nov 2025 23:39:57 +0100
Subject: [PATCH] Fix bug menu

---
 CHANGELOG.md  |  4 ++++
 manifest.json |  2 +-
 metadata.json |  4 ++--
 src/kaplus.js | 24 +++++++++---------------
 4 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c16bdff..e0b16b9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.4.12 (2025-11-11)
+
+- correction bug menu
+
 ## 1.4.11 (2025-11-11)
 
 - ajout des data collection permissions
diff --git a/manifest.json b/manifest.json
index a4ffa66..3625ac0 100644
--- a/manifest.json
+++ b/manifest.json
@@ -1,7 +1,7 @@
 {
   "manifest_version": 3,
   "name": "KAplus",
-  "version": "1.4.11",
+  "version": "1.4.12",
 
   "author": "Samuel Campos - netoik.io",
   "description": "Extension développée pour améliorer l'expérience de jeu KingsAge (fonctionne avec ou sans premium)",
diff --git a/metadata.json b/metadata.json
index bc1d297..3ecc606 100644
--- a/metadata.json
+++ b/metadata.json
@@ -5,8 +5,8 @@
       "firefox"
     ],
     "release_notes": {
-      "fr": "- ajout des data collection permissions",
-      "en-US": "- add data collection permissions"
+      "fr": "- correction bug menu",
+      "en-US": "- fix bug menu"
     }
   }
 }
\ No newline at end of file
diff --git a/src/kaplus.js b/src/kaplus.js
index b79f6fb..b0c82f3 100644
--- a/src/kaplus.js
+++ b/src/kaplus.js
@@ -32,22 +32,16 @@ function createRow(key, value) {
 }
 
 function shortcutElementReplace(elt, img, text) {
-	let imgElements = elt.getElementsByTagName("img");
-	for (let i=0; i<imgElements.length; i++) {
-		if (i === 0) {
-			elt.getElementsByTagName("a")[0].classList.add("has_notif");
-		}
-		imgElements[i].remove();
-		i --;
-	}
-
+    // If more than one hyperlink element found,
+    // then keep the last one but with href of the first one.
 	let aElements = elt.getElementsByTagName("a");
-	for (i=0; i<aElements.length; i++) {
-		if (i > 0) {
-			aElements[i].remove();
-			i --;
-		}
-	}
+    if (aElements.length > 1) {
+        aElements[aElements.length - 1].classList.add("has_notif");
+        aElements[aElements.length - 1].setAttribute("href", aElements[0].getAttribute("href"));
+        for (let i = aElements.length - 2; i >= 0; i --) {
+            aElements[i].remove();
+        }
+    }
 	
 	let spanImageElement = document.createElement("span");
 	spanImageElement.classList.add("shortcut_element_image");